fix: Prevent crashes caused by client_entergame and other minor bugs.#736
Merged
Nottinghster merged 3 commits intoopentibiabr:mainfrom Apr 3, 2024
kokekanon:main
Merged
fix: Prevent crashes caused by client_entergame and other minor bugs.#736Nottinghster merged 3 commits intoopentibiabr:mainfrom kokekanon:main
Nottinghster merged 3 commits intoopentibiabr:mainfrom
kokekanon:main
Conversation
the original bug is in I don't have how to test I don't use token EnterGame.toggleAuthenticatorToken EnterGame.toggleStayLoggedBox
luanluciano93
approved these changes
Mar 31, 2024
kokekanon
added a commit
to kokekanon/otclient.readme
that referenced
this pull request
Apr 17, 2024
The modification made to opentibiabr#736 of loadBox was in the wrong place in the code. causes display loadBox in old protocols.
13 tasks
Nottinghster
pushed a commit
that referenced
this pull request
Apr 20, 2024
* fix: [game_entergame] loadBox in old protocol The modification made to #736 of loadBox was in the wrong place in the code. causes display loadBox in old protocols. * fix: If you try to login without assets. * fix: indentation Reviewer: luanluciano93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.- fix: crash game_entergame if httpLoginBox is boolean
produced in #647
I think
httpLoginis always boolean, but I haven't studied pr 647 enough.Error:
2024-03-31.13-58-17.mp4
2.- fix: game_entergame if host nil windows is hidden
2024-03-31.13-56-20.mp4
fix:

3.- temp fix: game_entergame windows is not centered
2024-03-31.13-59-32.mp4
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Behavior
Actual
Do this and that doesn't happens
Expected
Do this and that happens
Fixes
# (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Test Configuration:
Checklist