fix: market browsing broken in pre-12.51 protocols#746
Merged
mehah merged 1 commit intoopentibiabr:mainfrom May 3, 2024
glecko:main
Merged
fix: market browsing broken in pre-12.51 protocols#746mehah merged 1 commit intoopentibiabr:mainfrom glecko:main
mehah merged 1 commit intoopentibiabr:mainfrom
glecko:main
Conversation
luanluciano93
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since 30b6702 any market browse messages by the client in protocols prior to 12.51 that have market enabled have been missing the header. This causes the server to interpret the item ID as the header, causing all kinds of wonky behavior depending on what the item ID is.
Behavior
Actual
If you attempt to browse a market item in a 9.x / 10.x / 11.x game server, the items info is not returned. Instead, depending on which item has been browsed, a variety of things can happen (you get disconnected, you walk in a direction, nothing at all).
Expected
Attempting to browse a market item in a 9.x / 10.x / 11.x game server should return the items information.
Fixes
# (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist