fix: enable chat mode on/off#792
Merged
luanluciano93 merged 1 commit intoopentibiabr:mainfrom Jun 26, 2024
Merged
Conversation
…pressing the button on console ui
luanluciano93
approved these changes
Jun 26, 2024
majestyotbr
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When clicking on the button to change chat mode, it wasn't working.
Chat mode wasn't beind save by the settings.
On first login, you always had chat enable and had to press enter twice to make it work.
Esc didn't disable chat.
Behavior
Actual
When clicking on the button to change chat mode, it wasn't working.
Chat mode wasn't being save by the settings.
On first login, you always had chat enable and had to press enter twice to make it work.
Esc didn't disable chat.
Expected
When clicking on the button to change chat mode it should change the text and disable/enable chat.
Chat mode should be saved on the settings
Esc disables chat.
Fixes
No Issues on Github.
Type of change
How Has This Been Tested
Open client, login, enable/disable chat.
Close client, open client again, chat should be the same accordingly to the last settings.
Test Configuration: