Skip to content

feat: menu hide action bar and hide spell cooldown group#793

Merged
luanluciano93 merged 3 commits intoopentibiabr:mainfrom
matheussf:feat-hide-cooldown-groups-and-actionbar
Jun 26, 2024
Merged

feat: menu hide action bar and hide spell cooldown group#793
luanluciano93 merged 3 commits intoopentibiabr:mainfrom
matheussf:feat-hide-cooldown-groups-and-actionbar

Conversation

@matheussf
Copy link
Copy Markdown
Contributor

@matheussf matheussf commented Jun 25, 2024

Description

Some people might want to use the client in old style way, not using actionbars or spell cooldown group.

  • Added Show spells cooldowns group in the option menu
  • Added Show action bars in the option menu
  • At first the hide cooldown group button near inventory doesn't hide properly.
    image
  • Hide spells cooldown group button wasn't synchronized with the spells cooldown group option in the menu.

Behavior

Actual

There's no option to hide them.

Fixes

No github issues.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Open the client, go into menu options check/uncheck "show action bar" or "show spell group cooldowns"
The menu configuration:
image

Both unchecked:
image
Action bar checked:
image
Spell group cooldowns checked:
image
Action bar and spell group cooldowns checked:
image

Test Configuration:

  • Server Version: Canary 13.32
  • Client: OTC
  • Operating System: Windows 11 23H2 (22631.3737)

@matheussf matheussf requested a review from luanluciano93 June 26, 2024 03:41
@matheussf
Copy link
Copy Markdown
Contributor Author

matheussf commented Jun 26, 2024

Found two bugs:

  • At first the hide cooldown group button near inventory doesn't hide properly.
    image
  • Hide spells cooldown group button wasn't synchronized with the spells cooldown group option in the menu.

Both are fixed now.

CC: @luanluciano93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants