Fix black and red squares behaviors

[OTArchive]

Description

Black squares are not showing around attacking creatures, and the red target square disappears when you are attacked.

Expected

Black squares on attacking creatures and red square when you are attacking.

Fixes

Please help me understand this so we can code a proper solution.
In ProtocolGame::parseCreaturesMark, if I set "isPermanent" to false, the squares issues seem to get solved:

2024-10-04.15-20-06.mp4

Canary and TFS always sends 0x01 for "isPermanent":
Server side reference

Am I missing something? Should squares always be timedSquares?

Fixes #898

[luanluciano93]

If the server sent: U32, U8 and U8, you must receive these bytes, even if you are not going to use them.

[OTArchive]

If the server sent: U32, U8 and U8, you must receive these bytes, even if you are not going to use them.

Yeah, but any idea why the current implementation is broken? Should squares always be timedSquares?

[luanluciano93]

if the problem is in isPermanent, just receive the byte and don't define it in the variable:

        msg->getU8();
        const bool isPermanent = false;

Anyway, it's interesting to test on an older version to see if the behavior is the same.

[OTArchive]

if the problem is in isPermanent, just receive the byte and don't define it in the variable:

        msg->getU8();
        const bool isPermanent = false;

Anyway, it's interesting to test on an older version to see if the behavior is the same.

Sure, but that would leave dead code, right?
You are right, we should look into older versions.

[OTArchive]

If the server sent: U32, U8 and U8, you must receive these bytes, even if you are not going to use them.

Turns out that using the byte in Canary 13.40 breaks it again

8.6 server reference:
https://github.com/otservme/global860/blob/571183a2858e638d49778cca914c8126bd6f17ce/sources/protocolgame.cpp#L1613