Skip to content

fix: limitsFloorView incorrect thing check when calculating visible floor#920

Merged
luanluciano93 merged 1 commit intomainfrom
fix-floor-view
Oct 12, 2024
Merged

fix: limitsFloorView incorrect thing check when calculating visible floor#920
luanluciano93 merged 1 commit intomainfrom
fix-floor-view

Conversation

@nekiro
Copy link
Contributor

@nekiro nekiro commented Oct 12, 2024

Description

In certain scenarios (probably broken maps) getThing(0) is not the wall nor the ground.
For example in canary map and the linked issue scenario, the first item on the tile is actually a wooden floor (441) which is neither a ground nor a wall, it's a ground border, thus this code incorrectly checks if there is a wall or a ground.

Behavior

In certain scenarios doesn't correctly show/hide floors

Actual

Described in #829

Expected

Described in #829

Fixes

Fix #829

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@mehah mehah deleted the fix-floor-view branch October 13, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Floor view algorithm

2 participants