Skip to content

fix: Cyclopedia TFS 13.10#926

Merged
luanluciano93 merged 6 commits intoopentibiabr:mainfrom
kokekanon:kokekanon/fix-cyclopedia-13.10
Oct 16, 2024
Merged

fix: Cyclopedia TFS 13.10#926
luanluciano93 merged 6 commits intoopentibiabr:mainfrom
kokekanon:kokekanon/fix-cyclopedia-13.10

Conversation

@kokekanon
Copy link
Copy Markdown
Contributor

@kokekanon kokekanon commented Oct 15, 2024

Description

i think tfs otland main repo only has bestiary and a part of characters

BESTIARY:

ERROR: ProtocolGame parse message exception (159 bytes, 0 unread, last opcode is 0xda (218), prev opcode is 0xffffffff (-1)): InputMessage eof reached
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1310)

CHARACTERS:

ERROR: ProtocolGame parse message exception (159 bytes, 0 unread, last opcode is 0xda (218), prev opcode is 0xffffffff (-1)): InputMessage eof reached
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1310)

otland/forgottenserver#4402

with these changes there is no packet error

image

image

does not break compatibility with 13.32 and 13.40
image

+
ERROR: Unable to load texture '/game_cyclopedia/images/tibiaCoin': unable to open file '/game_cyclopedia/images/tibiaCoin.png': not found
+ 
ERROR: Lua exception: /game_cyclopedia/tab/character/character.lua:322: attempt to perform arithmetic on field 'amount' (a nil value)
+

duplication widget of :

image
for not destroying the children

Behavior

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants