fix: Modify new page interaction

[xuanlid]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

创建页面时，取消创建历史备份的弹窗

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features
  • New pages are now created immediately without a confirmation prompt, while existing pages require confirmation before proceeding.
• Refactor
  • The page editing process has been streamlined to ensure prompt application of changes and automatic clearing of status messages.

[coderabbitai]

Walkthrough

The pull request modifies the logic within the createHistoryMessage function in PageSetting.vue. The updated control flow checks if the page is new; if so, it calls createPage() directly, bypassing user confirmation. For existing pages, it sets up variables and then calls a confirmation dialog before proceeding. An additional call to editPage() is now included in the exec function after updating the page message, and the history message state is reset after execution.

Changes

File	Change Summary
packages/plugins/.../PageSetting.vue	Refactored createHistoryMessage: new pages now call createPage() immediately; existing pages trigger a confirmation dialog, then call editPage() and reset history message.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant PS as PageSetting
    participant P as Page
    participant C as Confirmation Dialog

    U->>PS: Initiate page action
    alt New Page
        PS->>P: createPage()
    else Existing Page
        PS->>PS: Define message details
        PS->>C: open confirm() dialog
        C-->>PS: User confirms
        PS->>P: editPage()
        PS->>PS: Reset state.historyMessage
    end

Loading

Possibly related PRs

• fix: page or block save update breadcrumb incorrectly #820: The changes in the main PR, specifically the restructuring of the createHistoryMessage function in PageSetting.vue, are related to the modifications made to the handlePageUpdate function in the retrieved PR, as both involve updates to the PageSetting.vue file and adjustments to function signatures that impact page handling logic.

Suggested reviewers

• chilingling
• hexqi

Poem

Hopping through the code with a joyful beat,
I found a bug and made it neat.
New pages spring to life without delay,
While old ones pause and then convey.
With every hop, our functions gleam—
A bunny's dream in the coding stream!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29ee743 and 6d3cf34.

📒 Files selected for processing (1)

• packages/plugins/page/src/PageSetting.vue (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/plugins/page/src/PageSetting.vue

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: push-check

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.