Skip to content

Update CI: pin netmhc-bundle to v1.0.0, add conditional token check, standardize checkout@v4#172

Closed
iskandr wants to merge 3 commits into
masterfrom
update-ci-workflow
Closed

Update CI: pin netmhc-bundle to v1.0.0, add conditional token check, standardize checkout@v4#172
iskandr wants to merge 3 commits into
masterfrom
update-ci-workflow

Conversation

@iskandr
Copy link
Copy Markdown
Contributor

@iskandr iskandr commented Mar 16, 2026

Summary

  • Standardize main repository checkout from actions/checkout@v3 to actions/checkout@v4
  • Pin the netmhc-bundle checkout to ref: v1.0.0 for reproducible builds
  • Add if: ${{ secrets.NETMHC_BUNDLE_ACCESS_TOKEN != '' }} conditional to all netmhc-bundle-dependent steps (checkout, apt install, environment setup/tool verification) so the workflow doesn't fail in forks or contexts without the secret
  • Split the former "Run unit tests" step into a conditional "Set up netmhc-bundle environment" step (with tool verification) and a standalone "Run unit tests" step that conditionally configures netmhc-bundle paths if the directory exists

Test plan

  • Verify CI passes on this PR (in the openvax org where the secret exists)
  • Verify that forked repos without NETMHC_BUNDLE_ACCESS_TOKEN skip netmhc-bundle steps gracefully and still run tests
  • Confirm netmhc-bundle is checked out at the v1.0.0 tag

🤖 Generated with Claude Code

iskandr and others added 3 commits March 16, 2026 17:15
…standardize checkout@v4

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…on to v5

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
iskandr added a commit that referenced this pull request Mar 17, 2026
Incorporates the useful bit from PR #172.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
iskandr added a commit that referenced this pull request Mar 17, 2026
Supersedes PR #172 — the useful bit from that PR applied to the
new workflow structure.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@iskandr
Copy link
Copy Markdown
Contributor Author

iskandr commented Mar 17, 2026

Superseded by #171 (merged) and #173. The new workflow structure from #171 covers all the fixes from this PR. The only remaining bit (pinning netmhc-bundle to v1.0.0) is in #173.

@iskandr iskandr closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant