Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

[OTX/XAI] OTX XAI integration for class-wise, det and cls#85

Merged
goodsong81 merged 29 commits intootxfrom
dk/otx_xai_det
Dec 20, 2022
Merged

[OTX/XAI] OTX XAI integration for class-wise, det and cls#85
goodsong81 merged 29 commits intootxfrom
dk/otx_xai_det

Conversation

@dongkwan-kim01
Copy link
Copy Markdown
Contributor

@dongkwan-kim01 dongkwan-kim01 commented Nov 15, 2022

Summary

  1. Support explain mode for detection & classification
  2. Integration of class-wise saliency map for cls, det

This PR includes
Add DetectionExplainer class to mpa/det/explainer.py
Support ReciproCAM and class-wise saliency map to detection case
Add explain stage

Test Codes
Can test with OTX CLI(please refer OTX cli support, link)

@dongkwan-kim01 dongkwan-kim01 changed the title Dk/otx xai det [OTX/XAI] support OTX XAI detection models Nov 15, 2022
@dongkwan-kim01 dongkwan-kim01 marked this pull request as draft December 7, 2022 08:15
@dongkwan-kim01 dongkwan-kim01 changed the title [OTX/XAI] support OTX XAI detection models [OTX/XAI] OTX XAI integration for class-wise, det and cls Dec 7, 2022
@dongkwan-kim01 dongkwan-kim01 requested review from goodsong81, harimkang and negvet and removed request for goodsong81 December 15, 2022 02:12
@dongkwan-kim01 dongkwan-kim01 marked this pull request as ready for review December 15, 2022 02:14
@dongkwan-kim01
Copy link
Copy Markdown
Contributor Author

@goodsong81 @negvet @harimkang Hello, because of the termination date, could you review this PR?

Copy link
Copy Markdown
Contributor

@negvet negvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the good work! LGTM

while hasattr(dataset, 'dataset') and not isinstance(dataset, ImageTilingDataset):
dataset = dataset.dataset

if isinstance(dataset, ImageTilingDataset):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supporting ImageTilingDataset on the way.. It is better to do it separately, but not sure that we can afford it in terms of time. I would approve to keep it here :)

Copy link
Copy Markdown

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need minor fixes.

Copy link
Copy Markdown

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the conflict?
Sorry for late review, it's my bad.

@dongkwan-kim01
Copy link
Copy Markdown
Contributor Author

@goodsong81 Thank you for noticing. Resolved conflict and tested in the otx side.

@goodsong81 goodsong81 merged commit d4cecc3 into otx Dec 20, 2022
@goodsong81 goodsong81 deleted the dk/otx_xai_det branch December 20, 2022 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants