Python API: prevent string tensor constants to avoid crash#33659
Closed
amishijain123 wants to merge 2 commits intoopenvinotoolkit:masterfrom
Closed
Python API: prevent string tensor constants to avoid crash#33659amishijain123 wants to merge 2 commits intoopenvinotoolkit:masterfrom
amishijain123 wants to merge 2 commits intoopenvinotoolkit:masterfrom
Conversation
Author
|
Hi maintainers, |
p-wysocki
approved these changes
Jan 28, 2026
Contributor
p-wysocki
left a comment
p-wysocki
left a comment
There was a problem hiding this comment.
LGTM as a workaround. Let's continue investigation in 180103, where we'll implement proper fix. For now let's avoid crashes.
| _value, _shared_memory = _value.astype(_dtype), False | ||
|
|
||
| # Block unsupported string tensor constants | ||
| if isinstance(_value, np.ndarray) and _value.dtype.kind in ("U", "S", "O"): |
Contributor
There was a problem hiding this comment.
Suggested change
| if isinstance(_value, np.ndarray) and _value.dtype.kind in ("U", "S", "O"): | |
| if isinstance(_value, np.ndarray) and _value.dtype.kind in ("U", "S", "O", "a"): |
Contributor
|
I see that another PR has been opened which actually implements creating string constants instead of not allowing them at all. #33574 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
### Description
This PR prevents crashes when creating Constant nodes from string tensors
in the OpenVINO Python API.
Previously, passing a NumPy array with string dtype (e.g. dtype=str)
to
opset13.constant()resulted in a MemoryError or segmentation fault.Now, such inputs are explicitly rejected with a clear and user-friendly
TypeError.
Changes
Related issue
Fixes #23611