Skip to content

ci: add 30-minute timeout to test jobs#1150

Merged
vringar merged 1 commit intomasterfrom
ci/test-timeout
Mar 2, 2026
Merged

ci: add 30-minute timeout to test jobs#1150
vringar merged 1 commit intomasterfrom
ci/test-timeout

Conversation

@vringar
Copy link
Contributor

@vringar vringar commented Mar 2, 2026

Summary

  • Add timeout-minutes: 30 to the tests job to prevent indefinite hangs when crash-recovery tests deadlock

Tests normally complete in ~12 minutes. The 30-minute limit provides headroom for slow runners while preventing hung jobs from blocking the merge queue indefinitely (the repo-level merge queue timeout is 20 minutes, but the job itself had no timeout and would burn runner minutes for up to 6 hours).

Copilot AI review requested due to automatic review settings March 2, 2026 22:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a hard timeout to the CI tests job so matrix test runs can’t hang indefinitely and consume runner time, which helps keep the merge queue unblocked when crash-recovery tests deadlock.

Changes:

  • Set timeout-minutes: 30 on the tests job in the main CI workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vringar vringar added this pull request to the merge queue Mar 2, 2026
Merged via the queue into master with commit c75fce0 Mar 2, 2026
17 checks passed
@vringar vringar deleted the ci/test-timeout branch March 2, 2026 23:28
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.72%. Comparing base (12fae22) to head (79e9d6c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
- Coverage   56.75%   56.72%   -0.03%     
==========================================
  Files          40       40              
  Lines        3908     3908              
==========================================
- Hits         2218     2217       -1     
- Misses       1690     1691       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants