Monkey patch elasticsearch-env file so it parses on busybox.#3044
Merged
anuraaga merged 6 commits intoopenzipkin:masterfrom Mar 25, 2020
Merged
Monkey patch elasticsearch-env file so it parses on busybox.#3044anuraaga merged 6 commits intoopenzipkin:masterfrom
anuraaga merged 6 commits intoopenzipkin:masterfrom
Conversation
Member
|
I'm tempted to simplify this as all the detection is moot since we are in a fixed image we control.. |
…pkin into anuraaga-elasticsearch-script
codefromthecrypt
approved these changes
Mar 25, 2020
Member
codefromthecrypt
left a comment
There was a problem hiding this comment.
you can rewind the last commits if you disagree, but I built locally and seems ok!
Member
|
oops spoke too soon.. the error about thai segmentation pops up late. |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While elasticsearch docs do mention a requirement on bash, so far we haven't had issues running on busybox. elastic/elasticsearch#49612 unfortunately broke compatibility at the syntax level.
This might give motivation to install bash into our image if it continues, let's try once to hack around it and see how far it gets us. At the same time, I see some movement to support busybox in elastic/elasticsearch#52519 so it could work out fine in the end.
Fixes #3042