[GR-74008] Use memory_pressure for free memory on macOS.#13141
Open
graalvmbot wants to merge 1 commit intomasterfrom
Open
[GR-74008] Use memory_pressure for free memory on macOS.#13141graalvmbot wants to merge 1 commit intomasterfrom
memory_pressure for free memory on macOS.#13141graalvmbot wants to merge 1 commit intomasterfrom
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
fniephaus/74008/memory_pressure
branch
from
9c067e8 to
f8ea2ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The numbers reported by
vm_statappear to be notoriously off from the actual memory pressure, especially on machines that have been running for some time. This PR changes the detection to usememory_pressureinstead ofvm_stat.On my MacBook that's been up for some days, the
vm_stat-based detection reports only ~38,75% of free memory.memory_pressure, on the other hand, reports ~81% which matches what Activity Monitor and iStat Menus report.