Merged
Conversation
karelbilek
force-pushed
the
fix-action-2
branch
2 times, most recently
from
63181df to
4e97e55
Compare
Owner
|
Thanks @karelbilek, I also saw that golangci-lint kept failing so I fixed it myself by pulling the newer version. I see that your fix is better. Can you resolve the conflicts so the workflow can be improved even further? Thank you for your contributions! |
Update golangci-lint (which fixes the weird timeout), also use the action (which caches the results for faster CI), also fixes all the issues reported.
Contributor
Author
|
Fixed. I would like to merge this PR before all the others :) so the lints are there, and with the cache (so it's faster) (not related, but I wonder how to cache the dockers in the tests so they don't time out... but that's for other discussion :)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update golangci-lint (which fixes the weird timeout), also use the action (which caches the results for faster CI), also fixes all the issues reported.