add StopCtx function, to stop containers with context#1094
Open
GRbit wants to merge 1 commit intoorlangure:masterfrom
Open
add StopCtx function, to stop containers with context#1094GRbit wants to merge 1 commit intoorlangure:masterfrom
GRbit wants to merge 1 commit intoorlangure:masterfrom
Conversation
orlangure
reviewed
Dec 3, 2024
Owner
orlangure
left a comment
orlangure
left a comment
There was a problem hiding this comment.
Great idea, thank you for working on this.
Did you make sure the context is propagated all the way to the docker client that actually cancels things?
|
|
||
| defer func() { _ = g.log.Sync() }() | ||
|
|
||
| eg, eCtx := errgroup.WithContext(ctx) |
Owner
There was a problem hiding this comment.
I think that we don't need two copies of the same function. Instead, we need the Stop function to call StopCtx with the background context, and StopCtx should be the only function that has all the errgroup code.
Author
There was a problem hiding this comment.
Yes, I've checked that github.com/docker/docker/client.ContainerStop and github.com/docker/docker/client.ContainerRemove both take the same context. Though, I didn't this behavior specifically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed that code in my use case, hope it could be useful to other users.