Conversation
There was a problem hiding this comment.
Pull Request Overview
Bumps the supported CockroachDB versions across tests, defaults, fixtures, and documentation.
- Update test matrices in
preset_test.goandpreset/cockroachdb/README.md - Bump the
defaultVersionconstant inpreset.go - Align JSON fixture and top-level README table with new versions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| preset/cockroachdb/preset_test.go | Updated the list of tested CockroachDB versions |
| preset/cockroachdb/preset.go | Changed defaultVersion to v25.1.6 |
| preset/cockroachdb/README.md | Updated example test snippet with new versions |
| internal/gnomockd/testdata/cockroachdb.json | Bumped JSON fixture version field to v25.1.6 |
| README.md | Updated supported versions table for CockroachDB |
Comments suppressed due to low confidence (1)
README.md:121
- The table row for CockroachDB is missing the leading
|delimiter, which breaks markdown table formatting. Please prefix this line with|to maintain consistency with other rows.
CockroachDB | [Go package](https://github.com/orlangure/gnomock/tree/master/preset/cockroachdb) | [Reference](https://pkg.go.dev/github.com/orlangure/gnomock/preset/cockroachdb?tab=doc) | `v23.2.25`, `v24.1.18`, `v24.3.13`, `v25.1.6` | ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.