feat: 2163 mcp handlers accept options#2164
Draft
cdascoli-fountain wants to merge 1 commit intoorval-labs:masterfrom
Draft
feat: 2163 mcp handlers accept options#2164cdascoli-fountain wants to merge 1 commit intoorval-labs:masterfrom
cdascoli-fountain wants to merge 1 commit intoorval-labs:masterfrom
Conversation
Collaborator
|
Looks like tests are failing |
Member
|
It's great. I was expecting this to be necessary, so that's helpful. I'll check the details once the CI is successful 👍 |
Member
|
Hi, @cdascoli-fountain. Could you continue working on this PR? |
Collaborator
|
@froggy1014 yes please |
Contributor
I figured out that this one is duplicated |
Collaborator
|
@froggy1014 yep both these PR's seem stalled so didn't know if you wanted to submit a new one that contains what it needs and @soartec-lab feedback so we can merge and close these two PR's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Allows MCP handlers to accept optional
optionsargument that will be passed the the http-clientFix #2163
i didnt see any existing tests to add to for the mcp package-- if i missed em please point em out happy to add to them.