analysisd: fix off-by-one in OS_CleanMSG.#1824
Merged
ddpbsd merged 1 commit intoossec:masterfrom Jan 17, 2020
Merged
Conversation
When removing the '[ID xx facility.severity]' substring of a syslog message in `OS_CleanMSG` care needs to be taken to stay within the bounds of the msg buffer when advancing past the `] ` in the msg. Prev. to this commit the `pieces` pointer is incremented by 2 when there may be only 1 character remaining before the null terminator.
cpu
force-pushed
the
cpu-fix-os_cleanmsg-off-by-one
branch
from
c2d16bd to
353ef15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removing the
"[ID xx facility.severity] "substring of a syslog message inOS_CleanMSGcare needs to be taken to stay within the bounds of the msg buffer when advancing past the"] "in the msg.Prev. to this commit the
piecespointer is incremented by 2 when there may be only 1 character remaining before the null terminator.Resolves #1816