Improve error message in ossec-testrule for missing rule matches#2170
Merged
atomicturtle merged 1 commit intoossec:mainfrom Jan 23, 2026
Merged
Improve error message in ossec-testrule for missing rule matches#2170atomicturtle merged 1 commit intoossec:mainfrom
atomicturtle merged 1 commit intoossec:mainfrom
Conversation
Changed cryptic error 'currently_rule not set!' to a more helpful message that explains what's actually wrong and how to fix it. Old message: 'ossec-testrule: currently_rule not set!' New message: 'ossec-testrule: No rule matched for decoder '<decoder_name>'. Verify that rules exist for this decoder and check if rules have required dependencies (if_sid, if_matched_sid, if_matched_group, etc.).' This helps users quickly identify that: 1. The decoder matched but no rule matched 2. They should check if rules exist for this decoder 3. Rules may be missing required dependencies like if_sid Fixes issue ossec#2093 reported by stefanct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed cryptic error 'currently_rule not set!' to a more helpful message that explains what's actually wrong and how to fix it.
Old message:
'ossec-testrule: currently_rule not set!'
New message:
'ossec-testrule: No rule matched for decoder '<decoder_name>'.
Verify that rules exist for this decoder and check if rules have
required dependencies (if_sid, if_matched_sid, if_matched_group, etc.).'
This helps users quickly identify that:
Fixes issue #2093 reported by stefanct.