Merged
Conversation
Member
Author
|
I think I got the return right in c63b476, but I'm not totally positive. |
|
I always like to add some logging on memory failures, but tricky to do on some cases. Seems ok here. It might be better long term to have a saved buffer we can release on memory failure error, just so we can log things properly before exiting. Unrelated to this :) |
Member
Author
|
I can add some merrors to the failures, that shouldn't be too hard. |
Member
Author
|
I added some merrors, although I didn't do anything to help specify which one was erroring out. Not sure if it matters at that point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if returning 0 is the best option here, just copied it from issue #752