Fixed bug at logcollector that inhibited alerts about file reduction#848
Merged
ddpbsd merged 2 commits intoossec:masterfrom May 18, 2016
wazuh:fix-logcollector
Merged
Fixed bug at logcollector that inhibited alerts about file reduction#848ddpbsd merged 2 commits intoossec:masterfrom wazuh:fix-logcollector
ddpbsd merged 2 commits intoossec:masterfrom
wazuh:fix-logcollector
Conversation
Member
|
The windows agent build is seeing the following error, maybe just a missing include? |
Contributor
Author
|
It was a variable scope problem. Fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When OSSEC detects that a file size has been reduced, it updates this size into a local variable, but else it doesn't update it, so Logcollector is able to detect once that the current size of the file is lower than when the file was opened.
This fix makes logcollector update the cached size at each verification, allowing it to be more accurate comparing sizes and to alert if the file was shrunk.