Fixed memory error on CDB lists management#855
Merged
ddpbsd merged 1 commit intoossec:masterfrom May 27, 2016
wazuh:fix_cdblists
Merged
Fixed memory error on CDB lists management#855ddpbsd merged 1 commit intoossec:masterfrom wazuh:fix_cdblists
ddpbsd merged 1 commit intoossec:masterfrom
wazuh:fix_cdblists
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
cdb_read()gets less bytes thanvlen, there is no end-of-string andOS_MatchExecute()deals with uninitialized memory. Valgrind warns about this, and sometimes analysisd produces a segmentation fault when tries to match with a rule that references a CDB list with value checking.This should fix this problem.