Dichotomic search to add agents with authd#890
Merged
awiddersheim merged 1 commit intoossec:masterfrom Jul 12, 2016
wazuh:dichotomic-search
Merged
Dichotomic search to add agents with authd#890awiddersheim merged 1 commit intoossec:masterfrom wazuh:dichotomic-search
awiddersheim merged 1 commit intoossec:masterfrom
wazuh:dichotomic-search
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch solves the issue #873, speeding up the agent ID assignation at
ossec-authdby using dichotomic search.Currently, when assigning a new ID, OSSEC tries to use 1, 2, etc, until it finds the first empty ID. For each attempt, it opens the keys file and goes through it. So, the algorithmic efficiency is O(n^2).
Since the assigned IDs are always correlative, this implementation guesses the first free ID by splitting the entire list of possible values and testing only the central number. This way it achieves a linear-logarithmic efficiency, O(n log n).