Conversation
added 3 commits
August 1, 2016 16:04
(error) Uninitialized variables: mf_sum and sf_sum It's always good to initialize integer variables, at least to 0, because if you try to retrieve the variable before it gets assigned any actual (non-garbage) value, then you run the risk of retrieving a garbage value that might cause your program to crash, or worse, might corrupt memory. Found by https://github.com/bryongloden/cppcheck
Changed initialized value from 0 to NULL
Changed initialized value from NULL to "" REF: http://stackoverflow.com/a/18688992
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's always good to initialize the elements of a char array, at least to "", because if you try to retrieve an element before it gets assigned any actual (non-garbage) value, then you run the risk of retrieving a garbage value that might cause your program to crash, or worse, might corrupt memory.
Found by https://github.com/bryongloden/cppcheck