Update getremotelogs.sh to accept custom a SSH port#135
Merged
MarcOverIP merged 5 commits intooutflanknl:masterfrom Jan 14, 2021
Merged
Update getremotelogs.sh to accept custom a SSH port#135MarcOverIP merged 5 commits intooutflanknl:masterfrom
MarcOverIP merged 5 commits intooutflanknl:masterfrom
Conversation
github-actions
bot
added
docker
MarcOverIP
requested changes
Jan 14, 2021
Member
MarcOverIP
left a comment
MarcOverIP
left a comment
There was a problem hiding this comment.
Please change to:
echo "[X] Optional - need the remote system's ssh port to get logs as 4th parameter. Defaults to '22'
Member
|
Thanks for this PR, and thanks for letting us know you appreciate RedELK. PR looks good, and I think it is a great addition! Just one small text change before Im merging. |
Author
|
Thank you! Made the change! |
MarcOverIP
approved these changes
Jan 14, 2021
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Before anything else, thank you for RedELK! It's been a much welcome addition to and an essential part of our workflow.
This PR adds an SSH port argument to the
getremotelogs.shscript that defaults to22.Due to how our lab is structured, we have been using a custom version of RedELK where the teamserver pushes the logs. We finally decided to update our team server setup to match RedELK instead, but we can't use a standard SSH port for the
getremotelogs.shscript.I can undo the style changes if necessary. They were mostly to quiet down shellcheck.
Regarding the argument count check, I didn't see an issue with passing too many arguments, so opted for a
less thancheck to make the SSH port argument optional. Please correct me if I'm wrong.