fix(shell): builtin rm returns wrong exit code in quiet mode

[robobun]

Summary

• Fixed builtin rm returning exit code 0 instead of 1 when a file doesn't exist and .quiet() or .text() is used
• The next() function had a hardcoded done(0) that ignored the stored exit code, only affecting the quiet/pipe code path
• Also fixed onShellRmTaskDone to use POSIX-conventional exit code 1 instead of raw errno values

Closes #18161

Test plan

• New regression test test/regression/issue/18161.test.ts covering:
  • .quiet() throws on rm failure
  • .nothrow().quiet() returns non-zero exit code
  • .text() throws on rm failure
  • .quiet() returns 0 on successful rm
  • Exit code matches between quiet and non-quiet modes
• Verified test fails with USE_SYSTEM_BUN=1 (2 of 5 tests fail)
• Verified test passes with bun bd test
• Existing throw.test.ts tests pass
• Existing bunshell.test.ts tests have no new failures (4 pre-existing quiet subprocess timeout failures)

🤖 Generated with Claude Code

[robobun]

^{Updated 9:57 AM PT - Feb 20th, 2026}

❌ Your commit 623234fa has 6 failures in Build #37732 (All Failures):

• test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 aarch64
• test/js/third_party/prisma/prisma.test.ts - SIGABRT on 🐧 13 x64-asan
• test/cli/hot/watch-many-dirs.test.ts - pid 2629 segmentation fault on 🐧 25.04 x64
• test/regression/issue/24364.test.ts - 1 failing on 🪟 11 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🪟 2019 x64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🪟 2019 x64-baseline
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🪟 11 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 13 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 25.04 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 3.23 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 3.23 x64-baseline
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 3.23 x64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 25.04 x64-baseline
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 13 x64-baseline
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 13 x64-asan
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 25.04 x64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 13 x64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🍎 14 x64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🍎 13 x64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🍎 14 aarch64
• test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🍎 13 aarch64
• test/regression/issue/11297/11297.test.ts - 1 failing on 🪟 2019 x64
• test/regression/issue/11297/11297.test.ts - 1 failing on 🪟 11 aarch64

---

🧪   To try this PR locally:

bunx bun-pr 27280

That installs a local version of the PR into your bun-27280 executable, so you can run:

bun-27280 --bun

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

This PR fixes exit code handling in the shell rm builtin to preserve actual exit codes instead of always returning 0, and adds regression tests validating the fix for the .quiet() flag behavior.

Changes

Cohort / File(s)	Summary
Exit Code Handling src/shell/builtin/rm.zig	Updated the builtin completion logic to return the actual exit code stored in this.state.done.exit_code instead of always returning 0. Changed error handling to set exit code to 1 when errors are present, otherwise 0.
Regression Tests test/regression/issue/18161.test.ts	New test file validating .quiet() flag behavior with the rm command, covering failure scenarios with nonexistent files, success paths with existing files, and consistency checks between quiet and non-quiet variants.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: builtin rm returning wrong exit code in quiet mode, which matches the primary code changes.
Description check	✅ Passed	The description covers what the PR does, the root cause, and includes comprehensive test plans with verification steps.
Linked Issues check	✅ Passed	The PR directly addresses issue #18161 by fixing exit code handling in quiet mode and ensuring proper error throwing behavior.
Out of Scope Changes check	✅ Passed	All changes in rm.zig and the new test file are directly related to fixing the quiet mode exit code issue described in #18161.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

✅ 62323 — Looks good!

Reviewed 2 files across src/shell/builtin/ and test/regression/issue/: Fixes exit code handling in the shell rm builtin when quiet mode (.quiet() or .text()) is enabled, by propagating the stored exit code instead of hardcoding 0 and normalizing error exit codes to POSIX-conventional 1.