Skip to content

fix(types): add missing contentEncoding to S3Options type definition#27329

Merged
Jarred-Sumner merged 1 commit intomainfrom
claude/fix-s3-content-encoding-types
Mar 1, 2026
Merged

fix(types): add missing contentEncoding to S3Options type definition#27329
Jarred-Sumner merged 1 commit intomainfrom
claude/fix-s3-content-encoding-types

Conversation

@robobun
Copy link
Collaborator

@robobun robobun commented Feb 21, 2026

Summary

  • Adds the missing contentEncoding property to the S3Options TypeScript type definition in packages/bun-types/s3.d.ts
  • The runtime support for contentEncoding was added in PR feat(s3): add Content-Encoding header support for S3 uploads #26149 but the type definitions were not updated, causing TypeScript errors and missing IDE autocompletion

Closes #27328

Test plan

  • Verify contentEncoding appears in S3Options interface alongside contentDisposition
  • Existing runtime tests in test/js/bun/s3/s3.test.ts already cover the runtime behavior

🤖 Generated with Claude Code

The runtime support for `contentEncoding` was added in PR #26149 but the
TypeScript type definitions were not updated, causing TS errors and
missing IDE autocompletion.

Closes #27328

Co-Authored-By: Claude <noreply@anthropic.com>
@robobun robobun requested a review from alii as a code owner February 21, 2026 13:44
@robobun
Copy link
Collaborator Author

robobun commented Feb 21, 2026

Updated 6:22 AM PT - Feb 21st, 2026

❌ Your commit 858df1dc has 4 failures in Build #37877 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 27329

That installs a local version of the PR into your bun-27329 executable, so you can run:

bun-27329 --bun

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 21, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

A new optional property contentEncoding?: string was added to the S3Options interface in the Bun S3 type definitions, including JSDoc documentation describing its purpose and usage. No runtime logic changes were introduced.

Changes

Cohort / File(s) Summary
S3 Type Definitions
packages/bun-types/s3.d.ts
Added contentEncoding?: string optional property to the S3Options interface with comprehensive JSDoc documentation explaining the Content-Encoding header and providing usage examples.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding the missing contentEncoding property to the S3Options type definition.
Description check ✅ Passed The description provides good context about the fix and references the linked issue, but doesn't explicitly follow the template structure with the two required sections.
Linked Issues check ✅ Passed The PR adds contentEncoding to S3Options type definition as required by issue #27328, addressing the TypeScript error and enabling IDE autocompletion.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to adding the contentEncoding property to the S3Options interface with documentation, directly addressing the linked issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link
Contributor

claude bot commented Feb 21, 2026

858df — Looks good!

Reviewed 1 file in packages/bun-types/: Adds the missing contentEncoding property to the S3Options TypeScript type definition, aligning the types with the runtime support that was added in PR #26149.

@Jarred-Sumner Jarred-Sumner merged commit 915749f into main Mar 1, 2026
64 of 65 checks passed
@Jarred-Sumner Jarred-Sumner deleted the claude/fix-s3-content-encoding-types branch March 1, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[S3] contentEncoding is not working

2 participants