fix(types): add missing contentEncoding to S3Options type definition#27329
Merged
Jarred-Sumner merged 1 commit intomainfrom Mar 1, 2026
Merged
fix(types): add missing contentEncoding to S3Options type definition#27329Jarred-Sumner merged 1 commit intomainfrom
contentEncoding to S3Options type definition#27329Jarred-Sumner merged 1 commit intomainfrom
Conversation
Collaborator
Author
|
Updated 6:22 AM PT - Feb 21st, 2026
❌ Your commit
🧪 To try this PR locally: bunx bun-pr 27329That installs a local version of the PR into your bun-27329 --bun |
Contributor
|
No actionable comments were generated in the recent review. 🎉 WalkthroughA new optional property Changes
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contentEncodingproperty to theS3OptionsTypeScript type definition inpackages/bun-types/s3.d.tscontentEncodingwas added in PR feat(s3): add Content-Encoding header support for S3 uploads #26149 but the type definitions were not updated, causing TypeScript errors and missing IDE autocompletionCloses #27328
Test plan
contentEncodingappears inS3Optionsinterface alongsidecontentDispositiontest/js/bun/s3/s3.test.tsalready cover the runtime behavior🤖 Generated with Claude Code