release: v2.0 :tada: by xhyrom · Pull Request #80 · oven-sh/setup-bun

xhyrom · 2024-05-07T18:12:18Z

thanks for #76

Fixes #79
Fixes #81

* feat: add input for bun-version-file * docs: update example bun version file * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Workaround for actions/toolkit#1179 Fixes #79

Jarred-Sumner · 2024-05-21T14:07:29Z

Why .bunrc when bunfig.toml exists? If the goal is to just specify the bun version and no further config, why not .bun-version instead of .bunrc?

xhyrom · 2024-05-22T16:12:14Z

Why .bunrc when bunfig.toml exists? If the goal is to just specify the bun version and no further config, why not .bun-version instead of .bunrc?

Sure, that sounds better, we can do that ;)

dloetzke · 2024-05-24T08:57:38Z

Could it be a good idea to always check for a .bun-version file and use the version from there, even without any bun-version-file input being passed?
I don't think anyone would have such a file and not want the version in there to be used.

xhyrom · 2024-05-27T16:38:56Z

Could it be a good idea to always check for a .bun-version file and use the version from there, even without any bun-version-file input being passed? I don't think anyone would have such a file and not want the version in there to be used.

That's true but it leads to hidden behaviour and I'm not sure if that's what we want. Probably can be done by setting bun-version-file to .bun-version by default

Fixes #81

dloetzke · 2024-05-28T06:19:48Z

That's true but it leads to hidden behaviour and I'm not sure if that's what we want. Probably can be done by setting bun-version-file to .bun-version by default

Setting it as default might make sense, though then it'd be better to check for a bun-version input first/with priority (not sure which input would override the other one right now).
That would only cause hidden behavior if there is no bun-version nor bun-version-file input, but a .bun-version file exists.

xhyrom · 2024-06-17T20:59:51Z

Ready to merge, tomorrow

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` | --- ### Release Notes <details> <summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary> ### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2) [Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2) `oven-sh/setup-bun` is the github action for setting up Bun. This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81)) For more information, see [https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80) by [@xHyroM](https://togithub.com/xHyroM) 🎉 **Full Changelog**: oven-sh/setup-bun@v1...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apify/crawlee).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

ArnaudBarre · 2024-06-24T08:14:08Z

A small note in the release on why you decided this is major would be appreciated

Jarred-Sumner · 2024-06-24T10:38:33Z

A small note in the release on why you decided this is major would be appreciated

I’m curious too

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` | --- ### Release Notes <details> <summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary> ### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2) [Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2) `oven-sh/setup-bun` is the github action for setting up Bun. This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81)) For more information, see [https://github.com/oven-sh/setup-bun/pull/76](https://togithub.com/oven-sh/setup-bun/pull/76) by [@adeherysh](https://togithub.com/adeherysh) and [https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80) by [@xHyroM](https://togithub.com/xHyroM) 🎉 **Full Changelog**: oven-sh/setup-bun@v1...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday after 9am before 5pm" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

xhyrom · 2024-06-24T13:12:15Z

A small note in the release on why you decided this is major would be appreciated

This version changes the behavior when selecting which version to install. When you have:

- uses: oven-sh/setup-bun@v2

it'll now look to see if there's a .bun-version and if not, it'll install the latest version. Previously it installed latest version without checking this file. I know it's probably pointless but I was planning a few more breaking changes that didn't happen, and then I didn't think about it anymore. My apologies.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary> ### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2) [Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2) `oven-sh/setup-bun` is the github action for setting up Bun. This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81)) For more information, see [https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80) by [@xHyroM](https://togithub.com/xHyroM) 🎉 **Full Changelog**: oven-sh/setup-bun@v1...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/grafbase/grafbase).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` | --- ### Release Notes <details> <summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary> ### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2) [Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2) `oven-sh/setup-bun` is the github action for setting up Bun. This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81)) For more information, see [https://github.com/oven-sh/setup-bun/pull/76](https://togithub.com/oven-sh/setup-bun/pull/76) by [@adeherysh](https://togithub.com/adeherysh) and [https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80) by [@xHyroM](https://togithub.com/xHyroM) 🎉 **Full Changelog**: oven-sh/setup-bun@v1...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Wednesday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/mheob/config).

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oven-sh/setup-bun](https://redirect.github.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary> ### [`v2`](https://redirect.github.com/oven-sh/setup-bun/releases/tag/v2) [Compare Source](https://redirect.github.com/oven-sh/setup-bun/compare/v1...v2) `oven-sh/setup-bun` is the github action for setting up Bun. This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://redirect.github.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://redirect.github.com/oven-sh/setup-bun/issues/81)) For more information, see [https://github.com/oven-sh/setup-bun/pull/76](https://redirect.github.com/oven-sh/setup-bun/pull/76) by [@adeherysh](https://redirect.github.com/adeherysh) and [https://github.com/oven-sh/setup-bun/pull/80](https://redirect.github.com/oven-sh/setup-bun/pull/80) by [@xHyroM](https://redirect.github.com/xHyroM) 🎉 **Full Changelog**: oven-sh/setup-bun@v1...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/grafbase/grafbase).

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oven-sh/setup-bun](https://github.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` | --- ### Release Notes <details> <summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary> ### [`v2`](https://github.com/oven-sh/setup-bun/releases/tag/v2) [Compare Source](oven-sh/setup-bun@v1...v2) `oven-sh/setup-bun` is the github action for setting up Bun. This release introduces support for the `bun-version-file` option, fixes [#79](oven-sh/setup-bun#79), and adds bun paths & urls to the output ([#81](oven-sh/setup-bun#81)) For more information, see [#76](oven-sh/setup-bun#76) by [@adeherysh](https://github.com/adeherysh) and [#80](oven-sh/setup-bun#80) by [@xHyroM](https://github.com/xHyroM) 🎉 **Full Changelog**: <oven-sh/setup-bun@v1...v2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.valverde.cloud/Thilawyn/effect-fc/pulls/10 Co-authored-by: Renovate Bot <renovate-bot@valverde.cloud> Co-committed-by: Renovate Bot <renovate-bot@valverde.cloud>

adeherysh and others added 2 commits April 12, 2024 22:17

feat: add input bun-version-file (#76)

3ef79fe

* feat: add input for bun-version-file * docs: update example bun version file * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

refactor: reduce read from file code

a0f1a9b

xhyrom changed the title ~~release: 2.0 🎉~~ release: v2.0 🎉 May 7, 2024

autofix-ci bot and others added 27 commits May 7, 2024 18:12

[autofix.ci] apply automated fixes

116db81

feat: read from all known files if not specified

e95e252

[autofix.ci] apply automated fixes

3ab03f7

fix: just continue if file doesnt exist

7d417e1

[autofix.ci] apply automated fixes

97de633

fix: return output if found version

ff32c47

[autofix.ci] apply automated fixes

a61c3e7

fix: make whitespace in .tool-versions optional

13cc864

[autofix.ci] apply automated fixes

7df30a5

log loglog

2c99120

[autofix.ci] apply automated fixes

a06305c

log log log

3b5d993

[autofix.ci] apply automated fixes

0b54beb

better warnings, fix ci failing

ebd8028

[autofix.ci] apply automated fixes

ce012a6

feat: log obtained version

11f18d9

[autofix.ci] apply automated fixes

48d2521

build: bump version

33f36f9

[autofix.ci] apply automated fixes

77ae171

fix: add .zip extension if it's not present

f885433

Workaround for actions/toolkit#1179 Fixes #79

[autofix.ci] apply automated fixes

b9b566f

docs: add comment for easier understanding

6c61d0a

ci: more readable version

83142f7

ci: match name

92b0900

docs: add package.json and .tool-versions to bun-version-file examples

6eefc6a

ci: add cache test

1cdb57b

ci: install another pkg for cache test

6f448b3

xhyrom and others added 2 commits May 22, 2024 18:13

refactor: .bun-version instead .bunrc

b43e4d1

[autofix.ci] apply automated fixes

3458468

feat: add bun paths and url to output

ac64dab

Fixes #81

xhyrom linked an issue May 27, 2024 that may be closed by this pull request

[enhancement] Add bun paths and url to output #81

Closed

[autofix.ci] apply automated fixes

247a216

xhyrom added 7 commits June 3, 2024 22:33

build: upstream

e29b840

ci: test for .bun-version

275f7ae

feat: make .bun-version as default in bun-version-file

0900cf0

ci: remove cache before test

e02a6b5

ci: remove cache before test

c2df4e8

ci: remove cache before test

9e6c317

ci: remove cache before test

75cd831

xhyrom merged commit ef00e4a into main Jun 21, 2024

VVsxmja mentioned this pull request Jun 29, 2024

Guide for GitHub Actions may be outdated oven-sh/bun#12244

Closed

xhyrom deleted the dev branch July 15, 2024 18:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

release: v2.0 🎉 #80

release: v2.0 🎉 #80
xhyrom merged 49 commits intomainfrom
dev

xhyrom commented May 7, 2024 •

edited

Loading

Uh oh!

Jarred-Sumner commented May 21, 2024 •

edited

Loading

Uh oh!

xhyrom commented May 22, 2024 •

edited

Loading

Uh oh!

dloetzke commented May 24, 2024

Uh oh!

xhyrom commented May 27, 2024 •

edited

Loading

Uh oh!

dloetzke commented May 28, 2024

Uh oh!

xhyrom commented Jun 17, 2024

Uh oh!

ArnaudBarre commented Jun 24, 2024

Uh oh!

Jarred-Sumner commented Jun 24, 2024

Uh oh!

xhyrom commented Jun 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

xhyrom commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jarred-Sumner commented May 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xhyrom commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dloetzke commented May 24, 2024

Uh oh!

xhyrom commented May 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dloetzke commented May 28, 2024

Uh oh!

xhyrom commented Jun 17, 2024

Uh oh!

ArnaudBarre commented Jun 24, 2024

Uh oh!

Jarred-Sumner commented Jun 24, 2024

Uh oh!

xhyrom commented Jun 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xhyrom commented May 7, 2024 •

edited

Loading

Jarred-Sumner commented May 21, 2024 •

edited

Loading

xhyrom commented May 22, 2024 •

edited

Loading

xhyrom commented May 27, 2024 •

edited

Loading