fix: ensure mounted installable packages are installed as expected#1016
Merged
regisb merged 2 commits intooverhangio:masterfrom Mar 21, 2024
Merged
fix: ensure mounted installable packages are installed as expected#1016regisb merged 2 commits intooverhangio:masterfrom
regisb merged 2 commits intooverhangio:masterfrom
Conversation
regisb
reviewed
Mar 15, 2024
DawoudSheraz
changed the title
Danyal-Faheem
approved these changes
Mar 18, 2024
Contributor
Danyal-Faheem
left a comment
Danyal-Faheem
left a comment
There was a problem hiding this comment.
LGTM! 👍
I've tested it out on Tutor version 17.0.2 and it's working perfectly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #997
When xblocks and other installed packages are mounted, they are installed during image build. The dirs are copied over and then pip install takes place (resulting in egg-file generation). However, the dirs are not updated in host directories. When running tutor, the host files are re-mounted at run time. Due to missing egg-info, the installed packages no longer appear in pip list. This PR adds a small step during initialization that runs pip install on the mounted dirs if egg-info is missing.
Testing
tutor mounts add /path-to-openedx-scorm-xblockdoesn't automatically install scorm-xblock #997)tutor dev do init -l lmswould be enoughpip list | grep mnt. The mounted xblock(s) will show up.