feat(okms): secrets custom metadata #21085
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieumousnier
force-pushed
the
feat/MANAGER-19825
branch
from
27441ff to
04f1fbe
Compare
mathieumousnier
changed the title
mathieumousnier
requested review from
rjamet-ovh
and removed request for
a team
rjamet-ovh
reviewed
Dec 16, 2025
...r/apps/okms/src/modules/secret-manager/components/form/key-values-editor/KeyValuesEditor.tsx
Outdated
Show resolved
Hide resolved
rjamet-ovh
reviewed
Dec 16, 2025
...er/pages/drawers/edit-custom-metadata-drawer/EditCustomMetadataDrawerForm.component.spec.tsx
Outdated
Show resolved
Hide resolved
rjamet-ovh
reviewed
Dec 16, 2025
...okms/src/modules/secret-manager/pages/secret/general-information/GeneralInformation.page.tsx
Outdated
Show resolved
Hide resolved
rjamet-ovh
reviewed
Dec 16, 2025
...s/manager/apps/okms/src/common/components/key-value-tags-list/KeyValueTagsList.component.tsx
Show resolved
Hide resolved
mathieumousnier
force-pushed
the
feat/MANAGER-19825
branch
from
04f1fbe to
f2560bd
Compare
rjamet-ovh
approved these changes
Dec 16, 2025
rjamet-ovh
force-pushed
the
dev/okms-04
branch
from
dbaa930 to
e682b98
Compare
rjamet-ovh
requested review from
MarcMonchablon,
darsene and
yjaaouane
and removed request for
a team
github-actions
bot
added
the
has conflicts
ref: #MANAGER-20350 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-20350 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-16442 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-20499 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-20360 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-20499 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-19142 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-19142 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-20113 Signed-off-by: Romain Jamet <[email protected]>
added 5 commits
December 18, 2025 14:37
ref: #MANAGER-20113 Signed-off-by: Romain Jamet <[email protected]>
ref: #MANAGER-20113 Signed-off-by: Romain Jamet <[email protected]>
ref: #MANAGER-20113 Signed-off-by: Romain Jamet <[email protected]>
ref: #MANAGER-20113 Signed-off-by: Romain Jamet <[email protected]>
ref: #MANAGER-20113 Signed-off-by: Romain Jamet <[email protected]>
rjamet-ovh
force-pushed
the
dev/okms-04
branch
from
ad62a71 to
4f412ff
Compare
mathieumousnier
force-pushed
the
feat/MANAGER-19825
branch
from
90820c9 to
2827847
Compare
github-actions
bot
removed
the
has conflicts
pauldkn
approved these changes
Dec 19, 2025
...s/okms/src/modules/secret-manager/components/form/key-values-editor/KeyValuesEditor.spec.tsx
Show resolved
Hide resolved
pauldkn
reviewed
Dec 19, 2025
Contributor
pauldkn
left a comment
pauldkn
left a comment
There was a problem hiding this comment.
Your 3 first commits don't have "MANAGER" tag, they're referring to an old issue
ref: #MANAGER-19825 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-19825 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-19825 Signed-off-by: Mathieu Mousnier <[email protected]>
ref: #MANAGER-19825 Signed-off-by: Mathieu Mousnier <[email protected]>
mathieumousnier
force-pushed
the
feat/MANAGER-19825
branch
from
2827847 to
d801b4c
Compare
mathieumousnier
force-pushed
the
dev/okms-04
branch
from
9fc4c8e to
bf962ba
Compare
github-actions
bot
added
the
has conflicts
rjamet-ovh
force-pushed
the
dev/okms-04
branch
3 times, most recently
from
c7d0903 to
7884df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Reference: #MANAGER-19825
Caution
DO NOT MERGE THIS ONE
not until this is fixed on backend: https://jira.ovhcloud.tools/browse/EK-2192