[OCM] Make webdav URL absolute according to spec

[VicDeo]

resubmit of #34260

Description

Return an absolute URL for OCM WebDav discovery endpoint and change the storage to work with absolute discovery URLs

Note: It makes OCM-based sharing in backward incompatible without patching apps/files_sharing/lib/External/Storage.php

Related Issue

• Fixes OCM Returned endpoint relative #34631

Motivation and Context

To comply with OCM 1.0.0-proposal1 spec

How Has This Been Tested?

open URL owncloud.tld/ocm-provider/

expected

{"enabled":true,"apiVersion":"1.0-proposal1",
"endPoint":"http:\/\/owncloud.tld\/index.php\/apps\/federatedfilesharing",
"shareTypes":[{"name":"file",
"protocols":{"webdav":"http:\/\/owncloud.tld\/public.php\/webdav\/"}}]}

actual

{"enabled":true,"apiVersion":"1.0-proposal1",
"endPoint":"http:\/\/owncloud.tld\/index.php\/apps\/federatedfilesharing",
"shareTypes":[{"name":"file",
"protocols":{"webdav":"\/public.php\/webdav\/"}}]}

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[micbar]

@VicDeo Could you check on the failing acceptance test?

[VicDeo]

@micbar:

Could you check on the failing acceptance test?

None of OC/NC support absolute URL for OCM WebDav endpoint.
Support is implemented in this PR but Federated sharing is tested against daily that still doesn't support it

[phil-davis]

Support is implemented in this PR but Federated sharing is tested against daily that still doesn't support it

The CI here is old. If you rebase then it will run the webUISharingExternal acceptance test suite with a federated server running 10.2.1 and again with a federated server running daily-master-qa - probably they will both fail?

If there are fails against a 10.2.1 federated server, then that means that if this change is released, e.g. in 10.4.0, and someone is using federation and upgrades one of their servers to 10.4.0, then various federated connections to/from the 10.2.1 server are going to have trouble.

Doesn't there have to be a way that the new code can still talk remotely to an older server?

Please tell me if I have not understood correctly.

[VicDeo]

@phil-davis everything is correct.

OTOH it could be also a mistake in the spec. The spec is still in a "proposal" state and I have no feedback to my question so far
cs3org/OCM-API#37 (comment)

What we can do to be future-proof is to extract the part using absolute URL in storage (apps/files_sharing/lib/External/Storage.php) and merge it separately.
Thus by the time apps/federatedfilesharing/lib/Controller/OcmController.php is updated to expose an absolute URL instead of relative one the storage will need no changes to support it

[VicDeo]

Well, proposal has been merged...
We need to consider pushing this forward in near future.
The storage change has been moved into #37621

[DeepDiver1975]

old aka dead -> close