fix error suggestion select if the object is enclosed in paren#177
Open
Onyad wants to merge 1 commit intooxalica:mainfrom
Open
fix error suggestion select if the object is enclosed in paren#177Onyad wants to merge 1 commit intooxalica:mainfrom
Onyad wants to merge 1 commit intooxalica:mainfrom
Conversation
Owner
Thanks for the finding. Let's do this instead. There should be many other places relying on that every Expr AST node can be looked up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduce
there are no suggestions before the fix, after that there are suggestions
This is because there is no allocation in the crates/ide/src/def/lower.rs for the ast node Parent.
I do not know how best to solve this, so this is just a suggestion, perhaps it would be better to add an allocation for Paren.