Nexus external API: Use stronger types for BgpPeer addresses#10122
Open
jgallagher wants to merge 26 commits intomainfrom
Open
Nexus external API: Use stronger types for BgpPeer addresses#10122jgallagher wants to merge 26 commits intomainfrom
BgpPeer addresses#10122jgallagher wants to merge 26 commits intomainfrom
Conversation
9f59688 to
56e7ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #10082, and extends the stronger
RouterPeerTypeout from the internal API to the Nexus external API. The primary changes here are:BgpPeerto give stronger guarantees:BgpPeer::addris nowRouterPeerTypeinstead ofOption<IpAddr>(which permitted three distinct representations of "unnumbered":None,Some(0.0.0.0), andSome(::)).BgpPeer::router_lifetimemoved from being a top-level field to being nested inside theRouterPeerType::Unnumberedvariant, and its type is nowRouterLifetimeConfiginstead ofu16, adding enforcement of bounds.BgpPeer::interface_name(closesBgpPeer::interface_nameisn't faithfully persisted in the db - we should remove it #10104).BgpPeer:BgpPeerConfigSwitchPortSettingsSwitchPortSettingsCreateThe bulk of the diff is defining new versions of all these types and unit tests for the conversions they implement. The rest is fallout where these types touch other areas (e.g., datastore methods and bg tasks) and should be relatively straightforward.