fix!: require title when definitions are empty
#963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new condition that requires a root schema to contain a
titlewhen itsdefinitionsare empty.Previously, if this condition was not met, Typify would silently generate an empty output containing only boilerplate. This now results in an error, as a
titleordefinitionsare the bare minimum required to generate types.We can assume that any schema meeting this condition is at least a partially valid JSON Schema for Typify’s purposes. The
schemarscrate does not provide any mechanism for validating schemas, so this can be used as a reasonable heuristic instead.Fixes #516, fixes #313