Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I run into a problem to use this plugin in conjunction with the filemanager-webpack-plugin plugin.
The problem occurred because the filemanager plugin was executed on the 'afterEmit' hook whilst replace-in-file executes on the 'done' hook.
Therefore the files were copied before the content was replaced.
To fix this I introduced a new
hookproperty as a configuration option.It allows to specify which compiler hook the plugin should use and defaults to 'done'.
I had to restructure the code a bit and move the callback inside the
forEachloop to allow a different 'hook' value per option.Regards
Peter
Sidenote
I removed this condition because I didn't need it for my purpose but if you think this changes makes sense to be merged, I am happy to add it back.