Skip to content

[datetime2] Do not use export * as ns for webpack 4 compatibility #6421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adidahiya merged 1 commit into from
Oct 3, 2023
Merged

[datetime2] Do not use export * as ns for webpack 4 compatibility #6421

adidahiya merged 1 commit into from
Oct 3, 2023

Conversation

@kalekseev
Copy link
Contributor

@kalekseev kalekseev commented Oct 2, 2023

Fixes #6420

adidahiya
adidahiya approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kalekseev!

@adidahiya adidahiya merged commit edd84f7 into palantir:develop Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adidahiya adidahiya adidahiya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[datetime2] is not compatible with webpack 4

2 participants

@kalekseev @adidahiya