Add `size` prop to Button and ButtonGroup #7226

ggdouglas · 2025-02-04T17:23:05Z

Part of #7232

Proposed changes:

Adds a new size prop to replace the (now deprecated) small and large props on Button/AnchorButton and ButtonGroup.

svc-palantir-github · 2025-02-04T17:37:52Z

Add `size` prop to Button and ButtonGroup

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2025-02-04T18:18:07Z

Add new SizeSelect and use in Button/ButtonGroup interactive playgrounds

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2025-02-04T18:43:44Z

Add new SizeSelect and use in Button/ButtonGroup interactive playgrounds

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2025-02-04T20:22:03Z

Add new SizeSelect and use in Button/ButtonGroup interactive playgrounds

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2025-02-04T22:46:21Z

Add new SizeSelect and use in Button/ButtonGroup interactive playgrounds

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2025-02-04T23:14:02Z

Migrate all buttons with `small` prop

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2025-02-05T18:36:14Z

Preserve existing class resolution behavior for small/large props

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2025-02-05T21:03:42Z

Modify sizeClass to handle components without small variant

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

packages/core/src/common/classes.ts

packages/core/src/common/errors.ts

packages/core/src/common/classes.ts

svc-palantir-github · 2025-02-12T18:48:11Z

Wrap prop validation warning logging logic in logDeprecatedSizeWarning

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2025-02-13T17:34:59Z

Update ESLint deprecation ignore statements

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2025-02-14T06:11:30Z

Merge branch 'develop' into gdouglas/size-prop-buttons

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2025-02-14T06:39:06Z

Lint

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

jscheiny · 2025-02-14T18:54:38Z

packages/core/src/common/errors.ts

+    if (large && small) {
+        console.warn(
+            ns +
+                ` <${component}> large and small props are mutually exclusive. Please use size="large" or size="small" instead.`,
+        );
+    } else if (large) {
+        console.warn(ns + ` <${component}> large is deprecated. Please use size="large" instead.`);
+    } else if (small) {
+        console.warn(ns + ` <${component}> small is deprecated. Please use size="small" instead.`);
+    }


I think we want to log if these props are non null rather than just true. That way if someone is doing something like <Button small={someBooleanVariable} /> we properly log even when passing false.

Ah, yeah, good call. Added in 5337c00

svc-palantir-github · 2025-02-14T20:28:15Z

Check for non-null values in logDeprecatedSizeWarning

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

ggdouglas force-pushed the gdouglas/size-prop-buttons branch from 160037c to e5eb6e7 Compare February 4, 2025 18:28

ggdouglas force-pushed the gdouglas/size-prop-buttons branch from e5eb6e7 to 1ccfc06 Compare February 4, 2025 20:07

ggdouglas added Package: core Domain: API labels Feb 4, 2025

ggdouglas added 3 commits February 4, 2025 17:30

Add size prop to Button and ButtonGroup

61698a1

Rename SizeSelect -> LegacySizeSelect

eb1db25

Add new SizeSelect and use in Button/ButtonGroup interactive playgrounds

e900982

ggdouglas force-pushed the gdouglas/size-prop-buttons branch from 1ccfc06 to e900982 Compare February 4, 2025 22:30

Add size utility class

6e7909c

ggdouglas force-pushed the gdouglas/size-prop-buttons branch from 06c27eb to 6e7909c Compare February 4, 2025 22:46

Migrate all buttons with small prop

a82b046

ggdouglas mentioned this pull request Feb 4, 2025

Add size prop to more components #7228

Merged

Preserve existing class resolution behavior for small/large props

19204b3

ggdouglas force-pushed the gdouglas/size-prop-buttons branch from ece77a3 to 19204b3 Compare February 5, 2025 18:21

This was referenced Feb 5, 2025

Proposal: Consolidate small and large props on components #7232

Closed

Add size prop to large variant components #7234

Merged

Modify sizeClass to handle components without small variant

e2c033c

ggdouglas added the no changelog label Feb 5, 2025

jscheiny reviewed Feb 6, 2025

View reviewed changes

packages/core/src/common/classes.ts Outdated Show resolved Hide resolved

packages/core/src/common/errors.ts Outdated Show resolved Hide resolved

packages/core/src/common/classes.ts Outdated Show resolved Hide resolved

ggdouglas added 2 commits February 12, 2025 13:20

CR: Refactor sizeClass utility

bba8d5a

Wrap prop validation warning logging logic in logDeprecatedSizeWarning

0983901

ggdouglas requested a review from jscheiny February 12, 2025 18:36

ggdouglas added 2 commits February 13, 2025 12:16

Merge branch 'develop' into gdouglas/size-prop-buttons

840cd25

Update ESLint deprecation ignore statements

4bbe86b

Merge branch 'develop' into gdouglas/size-prop-buttons

27c0b00

Lint

8097d11

jscheiny reviewed Feb 14, 2025

View reviewed changes

Check for non-null values in logDeprecatedSizeWarning

5337c00

jscheiny approved these changes Feb 14, 2025

View reviewed changes

ggdouglas merged commit 9aac861 into develop Feb 14, 2025
13 checks passed

ggdouglas deleted the gdouglas/size-prop-buttons branch February 14, 2025 20:43

Add size prop to Button and ButtonGroup #7226

Add size prop to Button and ButtonGroup #7226

Uh oh!

Conversation

ggdouglas commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Part of #7232

Proposed changes:

Uh oh!

svc-palantir-github commented Feb 4, 2025

Add `size` prop to Button and ButtonGroup

Uh oh!

svc-palantir-github commented Feb 4, 2025

Add new SizeSelect and use in Button/ButtonGroup interactive playgrounds

Uh oh!

svc-palantir-github commented Feb 4, 2025

Add new SizeSelect and use in Button/ButtonGroup interactive playgrounds

Uh oh!

svc-palantir-github commented Feb 4, 2025

Add new SizeSelect and use in Button/ButtonGroup interactive playgrounds

Uh oh!

svc-palantir-github commented Feb 4, 2025

Add new SizeSelect and use in Button/ButtonGroup interactive playgrounds

Uh oh!

svc-palantir-github commented Feb 4, 2025

Migrate all buttons with `small` prop

Uh oh!

svc-palantir-github commented Feb 5, 2025

Preserve existing class resolution behavior for small/large props

Uh oh!

svc-palantir-github commented Feb 5, 2025

Modify sizeClass to handle components without small variant

Uh oh!

Uh oh!

Uh oh!

Uh oh!

svc-palantir-github commented Feb 12, 2025

Wrap prop validation warning logging logic in logDeprecatedSizeWarning

Uh oh!

svc-palantir-github commented Feb 13, 2025

Update ESLint deprecation ignore statements

Uh oh!

svc-palantir-github commented Feb 14, 2025

Merge branch 'develop' into gdouglas/size-prop-buttons

Uh oh!

svc-palantir-github commented Feb 14, 2025

Lint

Uh oh!

jscheiny Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

ggdouglas Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

svc-palantir-github commented Feb 14, 2025

Check for non-null values in logDeprecatedSizeWarning

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add `size` prop to Button and ButtonGroup #7226

Add `size` prop to Button and ButtonGroup #7226

ggdouglas commented Feb 4, 2025 •

edited

Loading