Rebase of #423 to add docs, hopefully ready for merge#1099
Merged
davidism merged 2 commits intopallets:masterfrom Sep 13, 2018
Merged
Rebase of #423 to add docs, hopefully ready for merge#1099davidism merged 2 commits intopallets:masterfrom
davidism merged 2 commits intopallets:masterfrom
Conversation
sirosen
force-pushed
the
type-datetime
branch
3 times, most recently
from
bf934ef to
2d12764
Compare
Add a docstring which defines the behaviors of the class, including default formats supported, usage of ``datetime.strptime`` and "first successful parse wins" behavior. Also add '%Y-%m-%d %H:%M:%S' to the default formats, as it is at least as commonly seen as '%Y-%m-%dT%H:%M:%S'. Minor test fix to handle the new format. Add ``click.DateTime`` to changelog.
davidism
force-pushed
the
type-datetime
branch
from
2d12764 to
5fe0b7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#423 is pending on a documentation addition.
As with many other old PRs, I don't think we should necessarily expect the original author to come back to things. Trying to cleanup the backlog.
I considered pushing to the #423 branch, but I wanted to drop the commit which makes things py2.6 compatible (since it's no longer relevant) and dropping a commit from someone else's PR is bad form.
So, to restate:
click.DateTimetype with a couple of tests%Y-%m-%d %H:%M:%S, which is pretty commonly used in my experiencecloses #423