add support for custom bash completers and choices

[ericfrederich]

After writing this I noticed #428 which mentioned #241 but thought I'd submit this pull request anyway.

This one uses completer and choices as keyword arguments using the same terminology as argcomplete

Dunno how hacky this is, but I got it to work for me. I basically pass some more context (the last parsed argument) to get_choices which it uses to look up either completer or choices attributes on the option.

[ericfrederich]

updated now with passing tests; added some tests for this new feature too

[untitaker]

I suspect this command is slightly buggy when completing a option with = like --local-opt=.

[ericfrederich]

@untitaker This patch should fix all the issues you mentioned with the previous one.

[untitaker]

Could you add a testcase that uses --local-opt=value instead of --local-opt value? As said I suspect that there's a bug in your code with invocations such
as:

cli subcommand --local-opt=<tab><tab>

Thanks!

On Thu, Sep 01, 2016 at 01:28:14PM -0700, Eric L. Frederich wrote:

@untitaker This patch should fix all the issues you mentioned with the previous one.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#643 (comment)

[ericfrederich]

@untitaker as I'm getting more familiar with Click's internals I'm going to close this request and do a better implementation later... hopefully soon!

[untitaker]

Okay cool. Feel free to email me if you're unclear about something.