Handle completion of Choices in Tuple Options#761
Closed
bobwhitelock wants to merge 1 commit intopallets:masterfrom
Closed
Handle completion of Choices in Tuple Options#761bobwhitelock wants to merge 1 commit intopallets:masterfrom
bobwhitelock wants to merge 1 commit intopallets:masterfrom
Conversation
Completion of Choice option values was recently added, in pallets#681. However, this does not cover Choice values within Tuple options. This commit adds similar handling so completion will cover these option values as well.
|
I was wondering if this issue was for click (version 6) to support having a click.option of type Tuple whose one tuple is itself a click.Choice type like so?: |
Member
|
Completion has changed significantly since this PR was posted. Would you or @stopthatcow review this to see if it's still needed and can be rebased? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completion of Choice option values was recently added, in #681. However, this does not cover Choice values within Tuple options. This commit adds similar handling so completion will cover these option values as well.