Skip to content

Add exclude-patterns option to flask run CLI#4189

Merged
davidism merged 1 commit into
pallets:mainfrom
mgu:feat/use-exclude-patterns-reloader
Feb 9, 2022
Merged

Add exclude-patterns option to flask run CLI#4189
davidism merged 1 commit into
pallets:mainfrom
mgu:feat/use-exclude-patterns-reloader

Conversation

@mgu
Copy link
Copy Markdown
Contributor

@mgu mgu commented Jul 6, 2021

Pass exclude_patterns to Werkzeug's run_simple function.
This configures a list of patterns to ignore when running the reloader.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@mgu mgu force-pushed the feat/use-exclude-patterns-reloader branch from 3dbd929 to 05bf062 Compare July 6, 2021 18:49
@mgu
Copy link
Copy Markdown
Contributor Author

mgu commented Jul 6, 2021

I don't know what tests I could add 🤷‍♂️

@davidism davidism added this to the 2.1.0 milestone Aug 5, 2021
@deconstructionalism
Copy link
Copy Markdown

I don't know what tests I could add 🤷‍♂️

I'd be happy to take a crack at adding tests and docs, if you'd like. I really need this feature as well

@paullilley
Copy link
Copy Markdown

Hi @deconstructionalism, @mgu - do you need help with writing a test for this? I'm happy to contribute if this has stranded.

@davidism davidism force-pushed the feat/use-exclude-patterns-reloader branch 2 times, most recently from 816fdc3 to 1412f71 Compare February 9, 2022 20:30
@davidism davidism force-pushed the feat/use-exclude-patterns-reloader branch from 1412f71 to beae124 Compare February 9, 2022 20:44
@davidism davidism merged commit 48ee204 into pallets:main Feb 9, 2022
Copy link
Copy Markdown

@fnhckgrx fnhckgrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spam removed

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add exclude-patterns option for werkzeug reloader

5 participants