Fix WebApp CI with dependency issues#836
Merged
kachick merged 5 commits intopankona:masterfrom Jun 20, 2023
kachick:sync-node-version-with-asdf
Merged
Fix WebApp CI with dependency issues#836kachick merged 5 commits intopankona:masterfrom kachick:sync-node-version-with-asdf
kachick merged 5 commits intopankona:masterfrom
kachick:sync-node-version-with-asdf
Conversation
kachick
changed the title
This was referenced Jun 20, 2023
Collaborator
Author
|
All CI passed 🎉 |
This was referenced Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for issue #{issue number}
Many dependabot PRs are failed from using old nodejs. See #827 as an example.
https://github.com/pankona/hashira/actions/runs/5258857960/jobs/9503647993#step:4:8
Updates
Looks like the maintainer is using asdf or rtx because this repository has a .tool-version file.
setup-node can parse it since v3
actions/setup-node#373
actions/setup-node@5b949b5
Using the same versions with CI should be better.
And we need to care microsoft/TypeScript#51567