Show hint about missing temperature setting in android 14.

[panmari]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @panmari, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience by providing clear feedback when a feature, specifically changing temperature units, is not supported on older Android versions. It introduces a mechanism to detect the device's Android SDK level and displays an informative message to users running Android 13 or earlier, preventing confusion and guiding them on potential feature requests.

Highlights

• Android Version Check: Implemented a check for the Android SDK version within the ChangeTemperatureUnitDialog to inform users if their device does not support changing temperature units (i.e., Android versions below 14).
• Device Information Integration: Integrated the device_info_plus package to programmatically retrieve the Android SDK version at runtime.
• Dependency Update: Added device_info_plus as a new dependency to the project.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• lib/widgets/change_temperature_unit_dialog.dart
  • Updated the constructor to accept an androidSdk integer.
  • Implemented conditional rendering to display a message for Android versions below 14.
• lib/widgets/popup_menu.dart
  • Imported the device_info_plus package.
  • Fetched the Android SDK version using DeviceInfoPlugin.
  • Passed the obtained androidSdk to the ChangeTemperatureUnitDialog.
• pubspec.lock
  • Added device_info_plus to the locked dependencies.
  • Added device_info_plus_platform_interface as a transitive dependency.
• pubspec.yaml
  • Added device_info_plus to the project dependencies.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request adds a necessary check for Android 14+ to inform users about the system-wide temperature unit setting. However, the implementation currently crashes on iOS because it attempts to fetch Android-specific device info without a platform check. I have provided suggestions to fix this crash and ensure the logic correctly handles non-Android platforms.

[gemini-code-assist]

The restriction on temperature unit settings is specific to Android 14. Since this dialog is also used on iOS (where this feature is supported), the check should only trigger when running on Android. Otherwise, iOS users will see an incorrect 'not supported' message.

Suggested change

	if (androidSdk < firstAndroidVersionWithTemperatureUnitSetting) {
	if (Theme.of(context).platform == TargetPlatform.android &&
	androidSdk < firstAndroidVersionWithTemperatureUnitSetting) {