Make CreateMultipartUploadResponse public#83
Merged
paolobarbolini merged 1 commit intopaolobarbolini:mainfrom Sep 27, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 91.03% 90.90% -0.14%
==========================================
Files 29 29
Lines 1361 1363 +2
==========================================
Hits 1239 1239
- Misses 122 124 +2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I noticed that this type was not accessible outside of your crate because we forgot to re-export it 🥲
As you can see on this method, it's white: https://docs.rs/rusty-s3/latest/rusty_s3/actions/struct.CreateMultipartUpload.html#method.parse_response
Which means that I can't return it or store it on my side.