feat: Unify tokenizer API and add support for pdb.icu and pdb.edge_ngram#53
Merged
isaacvando merged 23 commits intomainfrom Apr 20, 2026
Merged
feat: Unify tokenizer API and add support for pdb.icu and pdb.edge_ngram#53isaacvando merged 23 commits intomainfrom
isaacvando merged 23 commits intomainfrom
Conversation
57c05ff to
64e0831
Compare
philippemnoel
approved these changes
Apr 17, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 86.43% 89.54% +3.10%
==========================================
Files 16 17 +1
Lines 1342 1262 -80
Branches 288 262 -26
==========================================
- Hits 1160 1130 -30
+ Misses 99 75 -24
+ Partials 83 57 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
9b78f93 to
e4c6d16
Compare
b5aeff7 to
c06be59
Compare
Collaborator
Author
|
@philippemnoel I've made a lot of changes since you last reviewed this. Mind taking another look? It should be good to go now. |
rebasedming
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
I realized that we had a set of tokenizer functions in the indexing module that was used only for indexing, and then a completely different way to specify tokenizers for queries. This is a pretty bad user experience since they are really the same thing in each case. The function based approach is nicer because it makes it clearer what's required and allowed and makes it more direct to prevent SQL injection. I moved the previously indexing-specific approach to tokenizers out of the indexing module into a new tokenizer module and updated the query functions to use those tokenizer functions instead of their old idiosyncratic way.
The examples in the docs that use tokenizers will need to be updated when this is released.
What
Why
How
Tests