refactor: extract codec selection mechanics#136
Merged
jamessewell merged 2 commits intomainfrom May 1, 2026
Merged
Conversation
Add the ability to configure which columnar codecs are used via IndexSettings, and thread that configuration through serialization, segment writing, and merge paths.
stuhood
approved these changes
May 1, 2026
Collaborator
stuhood
left a comment
stuhood
left a comment
There was a problem hiding this comment.
This is going to be very likely to conflict during rebases, but that's ok as long as compilation fails in a useful way.
To that end, making sure the DEFAULT is only ever applied at the top, and never near the bottom of the stack will make things safer during rebase. You probably have a better sense of where that is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to configure which columnar codecs are used via IndexSettings, and thread that configuration through serialization, segment writing, and merge paths.