Skip to content

feat(tester): enable -Ztypeck for solc tests with TypeError annotations#737

Open
jose-blockchain wants to merge 1 commit intoparadigmxyz:mainfrom
jose-blockchain:fix/enable-ztypeck-solc-tests
Open

feat(tester): enable -Ztypeck for solc tests with TypeError annotations#737
jose-blockchain wants to merge 1 commit intoparadigmxyz:mainfrom
jose-blockchain:fix/enable-ztypeck-solc-tests

Conversation

@jose-blockchain
Copy link

@jose-blockchain jose-blockchain commented Feb 16, 2026

Summary

Fixes #663

  • Move --stop-after=parsing from base program args to per-file config in the solc tester
  • For solc tests with // TypeError: annotations (and no ParserError), pass -Ztypeck instead, running the full compiler pipeline including type checking
  • Add is_type_error() helper to SolcErrorKind
  • ~1593 solc tests now exercise the typechecker; exit code remains ignored since the typechecker is WIP

Test plan

  • All 6531 solc-solidity tests pass
  • All 198 UI tests pass
  • Clippy clean across workspace

Move --stop-after=parsing from base program args to per-file config so
it can be conditionally replaced. For solc tests that expect TypeError
(and no ParserError), pass -Ztypeck instead, running the full compiler
pipeline including type checking. Exit code remains ignored for these
tests since the typechecker is still WIP.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable -Ztypeck for some solc tests

1 participant