opencv: 0.88.9 -> 0.94.2#845
Merged
EgorPopelyaev merged 1 commit intoparitytech:masterfrom May 19, 2025
Merged
Conversation
c20bd7b to
18d76ae
Compare
18d76ae to
d138afb
Compare
Contributor
Author
|
@prybalko Upstream fix in signer was merged, would appreciate a review. |
Collaborator
|
@FlorianFranzen Hi Florian, thanks a lot for your contribution! I've tested your PR and will merge it. Sorry for the delay. |
EgorPopelyaev
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the release of opencv 4.9, the metadata-portal no longer builds without an update to the opencv bindings.
This PR updates these bindings as well as the underlying parity-signer bindings which have been updated upstream in the meantime as well. Additionally it pins substrate to the same version used by the signer.
For now this will fail to build on CI, as it still depends on a similar change to be made in the parity-signer code (see novasamatech/parity-signer#2450 for details).