Skip to content

Set the Noise prologue in the WebRTC handshake#2759

Closed
tomaka wants to merge 1 commit intoparitytech:mainfrom
tomaka:webrtc-prologue
Closed

Set the Noise prologue in the WebRTC handshake#2759
tomaka wants to merge 1 commit intoparitytech:mainfrom
tomaka:webrtc-prologue

Conversation

@tomaka
Copy link
Copy Markdown
Contributor

@tomaka tomaka commented Sep 16, 2022

Let's wait for libp2p-webrtc to support this as well before merging this PR.

cc libp2p/rust-libp2p#2903

@tomaka tomaka requested a review from melekes September 16, 2022 12:58
Copy link
Copy Markdown
Contributor

@mergify mergify Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Copy Markdown
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
        +424 ┊ smoldot::libp2p::collection::multi_stream::MultiStreamConnectionTask<TNow,TSubId>::new::h33a2c8aa87839408
         +95 ┊ <alloc::vec::Vec<T,A> as core::cmp::PartialOrd>::partial_cmp::haa56e24ee69ac59d
         -87 ┊ smoldot_light::json_rpc_service::state_chain::<impl smoldot_light::json_rpc_service::Background<TPlat>>::state_get_keys_paged::{{closure}}::{{closure}}::h234086d3023e1a25
         +16 ┊ data[0]
        +560 ┊ Σ [4 Total Rows]

Copy link
Copy Markdown
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes
Copy link
Copy Markdown
Contributor

melekes commented Oct 13, 2022

Closing in favor of #2807.

@melekes melekes closed this Oct 13, 2022
@tomaka tomaka deleted the webrtc-prologue branch October 13, 2022 07:50
mergify Bot pushed a commit that referenced this pull request Oct 13, 2022
Updates #2759
See melekes/rust-libp2p#10 and
libp2p/specs#412 (comment)

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants